[PATCH] D65793: [UpdateTestChecks] Update tests option

Kai Luo via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 3 00:52:14 PST 2019


lkail marked an inline comment as done.
lkail added inline comments.


================
Comment at: llvm/trunk/utils/update_analyze_test_checks.py:107
     for l in run_lines:
+      if '|' not in l:
+        common.warn('Skipping unparseable RUN line: ' + l)
----------------
lkail wrote:
> Hi @xbolva00 , I don't understand why skipping lines without '|'. There are still many autogenerated test cases in backend written kinda like
> ```
> ; RUN: llc ... \
> ; RUN: | FileCheck ...
> ```
Sorry for disturbing you, https://reviews.llvm.org/D70941 should have solved my concern.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D65793/new/

https://reviews.llvm.org/D65793





More information about the llvm-commits mailing list