[PATCH] D70933: Revert "[InstCombine] keep assumption before sinking calls"

Bob Haarman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 2 17:38:33 PST 2019


inglorion created this revision.
inglorion added reviewers: rnk, jdoerfert, efriedma, xbolva00.
Herald added a subscriber: hiraditya.
Herald added a project: LLVM.
inglorion added a comment.

@rnk suggested on D70749 <https://reviews.llvm.org/D70749> to do a simple revert of D69477 <https://reviews.llvm.org/D69477>. That's what this is.


This reverts commit c3b06d0c393e533eab712922911d14e5a079fa5d <https://reviews.llvm.org/rGc3b06d0c393e533eab712922911d14e5a079fa5d>.

Reason for revert: Caused miscompiles when inserting assume for undef.

Fixes PR44154.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D70933

Files:
  llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
  llvm/test/Transforms/InstCombine/assume-replacing-call.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70933.231801.patch
Type: text/x-patch
Size: 8876 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191203/e22b2045/attachment.bin>


More information about the llvm-commits mailing list