[PATCH] D70894: [asan] Remove debug locations from alloca prologue instrumentation

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.

I think this is fine. The original change was about the coverage callback location.



================
Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:2999
   IRBuilder<> IRB(InsBefore);
-  IRB.SetCurrentDebugLocation(EntryDebugLocation);
 
   // Make sure non-instrumented allocas stay in the entry block. Otherwise,
----------------
aprantl wrote:
> Can there be calls anywhere in the prologue? If yes, this may cause a verifier error i any of these calls get inlined. What does the commit message for the deleted statements say?
Yes, but they can not be inlined.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70894/new/

https://reviews.llvm.org/D70894