[PATCH] D70298: [LV] Avoid considering scalar-with-predication instructions as also uniform-after-vectorization, fix PR40816

Ayal Zaks via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 2 15:03:02 PST 2019


Ayal added a comment.

In D70298#1763967 <https://reviews.llvm.org/D70298#1763967>, @fhahn wrote:

> It looks like this also fixes https://bugs.llvm.org/show_bug.cgi?id=43951. The reproducer there might be a good source for a test case as well.


Agreed, thanks for pointing out! PR43951 exhibits a similar pattern of a load-from-constant-array used for computing the (tiny) trip count, eventually recognized as both scalar-with-predication and uniform-after-vectorization, and hence fixed by this patch. PR43951 has a (redundant) OR reduction instead of PR40816's store, but this distinction seems irrelevant in terms of test coverage.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70298/new/

https://reviews.llvm.org/D70298





More information about the llvm-commits mailing list