[PATCH] D70620: [CommandLine] Add callbacks to Options
Chris Bieneman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 2 14:44:10 PST 2019
beanz added a comment.
I like the idea behind this. I provided more detailed feedback to Don off-list, but I really don't like the `const void*` parameter to the callback functions. I think we can make that match the parser data type, and have compile-time errors for type mismatches. That would be vastly preferable to casting void pointers.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70620/new/
https://reviews.llvm.org/D70620
More information about the llvm-commits
mailing list