[PATCH] D70749: [InstCombine] do not insert nonnull assumption for undef

[Bob Haarman via Phabricator via llvm-commits]

inglorion added a comment.

> Or just avoid sinking for these cases and do not generate llvm.assume calls.

We can do that, too. But as you pointed out on D69477 <https://reviews.llvm.org/D69477>

> I benchmarked spec2006int with -instcombine-code-sinking=false and I observed major regressions.

So I prefer to leave sinking alone and just not generate the nonnull assumes for undefs. That gets the nonnull undef case back to where it was before D69477 <https://reviews.llvm.org/D69477>, while leaving everything else alone.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70749/new/

https://reviews.llvm.org/D70749