[PATCH] D70758: [PowerPC][NFC] Rename record instructions to use r suffix instead of o

[Jinsong Ji via Phabricator via llvm-commits]

jsji added a comment.

In D70758#1765982 <https://reviews.llvm.org/D70758#1765982>, @jhibbits wrote:

> I second @nemanjai, the lowercase 'o' suffix stands out to me as a clear indicator of it being punctuation, not a letter in the instruction.  I would much rather see ANDIo than ANDIr, the 'r' just doesn't look right when reading over it.  My vote is to reject.  It looks like a lot of churn without much benefit.


I understand that it might not be a big problem if you are familiar with the code base, but it is confusing to new comers.

For example, if you are discussing about some optimization related to ADD-o,
then you don't know exactly what you are talking about.

You will need to clarify more :

  are you talking about big O or small o? 

  are you talking about assembly addo or opcode ADDO? 

This is an effort to avoid confusion for newcomers, especially when dealing with assembly as well.

If `r` is not as straightforward as it should be, how about `_r`? eg: `ANDI_r` instead of `ANDIo`. Or any other suggestions?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70758/new/

https://reviews.llvm.org/D70758