[PATCH] D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions.

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 2 11:31:05 PST 2019


aprantl added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DbgEntityHistoryCalculator.cpp:265
 
-      if (MI.isDebugInstr())
+      if (MI.isDebugInstr() || MI.isKill())
         continue;
----------------
this needs a comment. I don't really understand the reasoning in the patch description either, so if you could explain why this is safe/correct, that would help me!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70497/new/

https://reviews.llvm.org/D70497





More information about the llvm-commits mailing list