[PATCH] D70672: [DebugInfo] Don't sink DBG_VALUEs past other DBG_VALUEs of the same variable location

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

Could you please add the motivating example from the description into one of the comments?

Otherwise I think this looks reasonable!



================
Comment at: llvm/lib/CodeGen/MachineSink.cpp:117
+    /// debug instructions to sink.
+    DenseMap<unsigned, TinyPtrVector<SeenDbgUser>> SeenDbgUsers;
+
----------------
I have a suspicion that on average, this DenseMap will have very few entries since it contains registers that hold variable values. Would it make sense to use a SmallDenseMap here? Or does it not because the DenseMap is being reused?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70672/new/

https://reviews.llvm.org/D70672