[PATCH] D70908: [scudo][standalone] Add chunk ownership function

Kostya Kortchinsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 2 13:21:23 PST 2019


cryptoad marked an inline comment as done.
cryptoad added a comment.

In D70908#1765712 <https://reviews.llvm.org/D70908#1765712>, @hctim wrote:

> So the model presented asserts that if the chunk header is truncated, the pointer is not owned by us. Is this WAI? I can forsee that a chunk header was truncated, and then the pointer to the associated allocation is checked for ownership, which the ownership will fail as the chunk header check didn't succeed.


I think that not claiming ownership of a corrupted chunk is something we can live with.
The ownership concept for tcmalloc has strong requirements, which I think are fulfilled by this implementation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70908/new/

https://reviews.llvm.org/D70908





More information about the llvm-commits mailing list