[PATCH] D70910: [compiler-rt] Add a critical section when flushing gcov counters

Mon Dec 2 12:28:02 PST 2019

dmajor added a subscriber: froydnj.
dmajor added a comment.

In D70910#1765633 <https://reviews.llvm.org/D70910#1765633>, @froydnj wrote:

> In D70910#1765583 <https://reviews.llvm.org/D70910#1765583>, @dmajor wrote:
>
> > The extra setup/teardown work for Windows relative to Linux is unfortunate. How would you feel about using an SRWLock instead?
>
>
> Are there minimum Windows version requirements for compiler-rt?  SRWLock is only available on Win7 forward, I think.

I believe SRWLocks arrived in Vista. Anyway, I don't know about compiler-rt specifically, but LLVM in general has required Win7 since 2015: http://llvm.org/viewvc/llvm-project?view=revision&revision=249332

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70910/new/

https://reviews.llvm.org/D70910