[PATCH] D70030: [MachineBlockPlacement] Update UnscheduledPredecessors when tail duplicate delete a block.

Ana Pazos via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 2 10:25:11 PST 2019


apazos added a comment.

The change looks good to me. Thanks for adding the test!



================
Comment at: llvm/test/CodeGen/ARM/block-placement-tail-duplication.mir:5
+# The test used to cause Assertion `Chain.UnscheduledPredecessors == 0 && \
+# "Attempting to place block with unscheduled predecessors in worklist."' failed.
+# CHECK-LABEL: name: test_func
----------------
You might want to add  REQUIRES: asserts. Or maybe explain what the  CHECK-NOT: bb.14.bb58 means


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70030/new/

https://reviews.llvm.org/D70030





More information about the llvm-commits mailing list