[PATCH] D70533: [AArch64] Fix a bug with jump table generation

[Oliver Stannard (Linaro) via Phabricator via llvm-commits]

ostannard requested changes to this revision.
ostannard added inline comments.
This revision now requires changes to proceed.


================
Comment at: llvm/lib/Target/AArch64/MCTargetDesc/AArch64AsmBackend.cpp:325
     return (Value >> 2) & 0x3ffffff;
   case FK_NONE:
   case FK_Data_1:
----------------
This isn't handled in `valueFitsIntoFixupKind`, and probably shouldn't hit the default of `true` if `Value` is non-zero.


================
Comment at: llvm/lib/Target/AArch64/MCTargetDesc/AArch64AsmBackend.cpp:332
+      Ctx.reportError(Fixup.getLoc(), "fixup value too large for data type!");
+    // Fall through ...
   case FK_SecRel_2:
----------------
This should be the `LLVM_FALLTHROUGH` macro to suppress compiler warnings.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70533/new/

https://reviews.llvm.org/D70533