[PATCH] D70660: Add initial tests for update_{llc,cc}_test_checks.py

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

I have two minor comments, neither is blocking. @MaskRay @xbolva00, please review and accept without waiting for me, I'm fine with this.

- We still have the "inputs" folder in which everything lives. I could see the '.ll' and '.ll.expected' to live in their but why the tests?
- The `--function-signatures` test has manual check lines. We should probably move to a '.expected' file as well here.



================
Comment at: llvm/test/tools/UpdateTestChecks/update_test_checks/basic.test:44
+# FUNCSIG-NEXT:  +; CHECK-SAME: (<2 x i8> {{\[}}[X:%.*]], <2 x i8> {{\[}}[Y:%.*]])
+# FUNCSIG-NEXT:   ; CHECK-NEXT:    ret <2 x i8> zeroinitializer
----------------
Shouldn't we have multiple .expected files instead? I see myself struggle with the escaping already.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70660/new/

https://reviews.llvm.org/D70660