[PATCH] D70757: [ms] Add @feat.00 magic symbol to COFF object files from AsmParser

[Eric Astor via Phabricator via llvm-commits]

epastor added a comment.

In D70757#1762394 <https://reviews.llvm.org/D70757#1762394>, @rnk wrote:

> I don't think we should do this implicitly. Assembler should be a low level representation of what the programmer wants in the symbol table. That includes @feat.00. There is existing nasm documentation covering this. Basically, this is something the programmer has to know if they want to target windows:
>  https://nasm.us/doc/nasmdoc7.html


Hang on. NASM documents the following:

> Former can be easily achieved with any NASM version by adding following line to source code:
> 
>   $@feat.00 equ 1
> 
> As of version 2.03 NASM adds this absolute symbol automatically. If it's not already present to be precise.

Would it be acceptable to match NASM, adding the symbol automatically unless it's already defined? Or do we want to stick closer to the ideal that we emit no symbols other than those explicitly given?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70757/new/

https://reviews.llvm.org/D70757