[PATCH] D70894: [asan] Remove debug locations from alloca prologue instrumentation

Vedant Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 2 09:11:39 PST 2019


vsk added a comment.

Looks reasonable to me, but I'll let someone more familiar with asan give an lgtm.



================
Comment at: llvm/test/Instrumentation/AddressSanitizer/debug-info-alloca.ll:1
+; Checks that asan instrumentation does not include line numbers as debug information.
+; Line info in an instrumentation instruction within the prologue would fool findPrologueEndLoc
----------------
nit: s/asan instrumentation/asan prologue/ ?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70894/new/

https://reviews.llvm.org/D70894





More information about the llvm-commits mailing list