[PATCH] D70691: Optimization record for bytecode input missing- PR44000

[Erich Keane via Phabricator via llvm-commits]

erichkeane added a comment.

unique_ptr already has a 'bool' builtin to its state (one that this code checks later anyway), so there isn't a good reason to return a bool here.  Otherwise I think I'm OK with this.

I'd like @thegameg to have a chance to take a look to make sure everything this is doing is necessary, so you should perhaps hold off until ~Weds/Thurs before committing.



================
Comment at: clang/lib/CodeGen/CodeGenAction.cpp:87
+  // be an empty file. If it returns false, then there is an error.
+  static bool setOptRecordFile(const CodeGenOptions CGOpts, DiagnosticsEngine &Diags,
+                               LLVMContext &Ctx,
----------------
This should just make/return OptRecordFile rather than a bool.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70691/new/

https://reviews.llvm.org/D70691