[PATCH] D70734: [VPlan] Add basicblocks() and loop_basicblocks iterators.

[Florian Hahn via Phabricator via llvm-commits]

fhahn marked an inline comment as done.
fhahn added inline comments.


================
Comment at: llvm/lib/Transforms/Vectorize/VPlan.h:1404
+  /// the loop blocks.
+  iterator_range<vpbb_iterator_adaptor> basicblocks() {
+    VPRegionBlock *TopRegion = dyn_cast<VPRegionBlock>(Entry);
----------------
gilr wrote:
> basicBlocks()?
I am not sure. I think for most iterator ranges we use lower case naming, with underscores, but I am not sure why. Personally, I think `basicBlocks()` looks a bit odd. Same for `loopBasicBlocks`. But I'd happily change the name, if there's a strong preference.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70734/new/

https://reviews.llvm.org/D70734