[PATCH] D70893: [Object/ELF] - Refine the error reported when section's offset + size overruns the file buffer.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 2 06:01:20 PST 2019


jhenderson added a comment.

Thanks for this. Just one comment.



================
Comment at: llvm/include/llvm/Object/ELF.h:414
+        Twine::utohexstr(Offset) + ") + sh_size (0x" + Twine::utohexstr(Size) +
+        ") that is greater than the file size " + Twine::utohexstr(Buf.size()));
 
----------------
The file size should be in brackets and have the 0x prefix (i.e. `file size (0x1234)`).


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70893/new/

https://reviews.llvm.org/D70893





More information about the llvm-commits mailing list