[PATCH] D70855: [llvm-readobj/llvm-readelf] - Simplify the code that dumps versions.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with two minor fixes.



================
Comment at: llvm/test/tools/llvm-readobj/elf-verneed-invalid.test:549-550
+
+## In this case SHT_GNU_verneed is linked to the custom dynamic string table, which name
+## is not ".dynstr". Check we handle this case properly.
+
----------------
the custom -> a custom
which name is not ".dynstr" -> which is not called ".dynstr"


================
Comment at: llvm/test/tools/llvm-readobj/elf-verneed-invalid.test:588-592
+  - Name:  .gnu.version_r
+    Type:  SHT_GNU_verneed
+    Flags: [ SHF_ALLOC ]
+    Link:  .custom.dynstr
+    Info:  1
----------------
These values aren't aligned with AddressAlign


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70855/new/

https://reviews.llvm.org/D70855