[PATCH] D70781: AMDGPU: Fix handling of infinite loops in fragment shaders

Carl Ritson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 2 02:23:30 PST 2019


critson added a comment.

I think there are two potential problems with this change (with the caveat that I have a heavy cold so I might not be thinking clearly):

1. The extra export is for not great for performance as it introduces an unnecessary stall at the end of the shader.
2. The extra export overwrites the set of active lanes set by a correct export done earlier in the shader.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70781/new/

https://reviews.llvm.org/D70781





More information about the llvm-commits mailing list