[PATCH] D70862: [ARM][AArch64] Complex addition Neon intrinsics for Armv8.3-A

Tim Northover via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 2 01:37:49 PST 2019


t.p.northover accepted this revision.
t.p.northover added a comment.
This revision is now accepted and ready to land.

> Why are you only implementing rot90 and rot270 intrinsics? My quick calculations made rot0 and rot90 the natural ones to implement a bog-standard complex multiplication, but even if I slipped up there I'd expect the others to be useful in some situations.

Sorry, ignore that. I didn't notice you were doing the addition instructions rather than multiplication. LGTM!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70862/new/

https://reviews.llvm.org/D70862





More information about the llvm-commits mailing list