[PATCH] D70874: [X86] Add initialization of MXCSR in llvm-exegesis
Pengfei Wang via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Dec 1 02:17:49 PST 2019
pengfei added a comment.
> I'm not sure I understand why this needs to be initialized. Why don't we need to do it for FPCW?
I'm sorry for not giving comments. Yes, we do need for FPCW if this is a reasonable approach. But I'm not sure if we need to explicatly initialize registers like MXCSR and FPCW or not either.
Can we just return a `MCInstBuilder(X86::NOOP)` for them to make the check pass (In Assembler.cpp L44, it judges the `IsSnippetSetupComplete` by checking if the return value is empty).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70874/new/
https://reviews.llvm.org/D70874
More information about the llvm-commits
mailing list