[PATCH] D70557: [lld][COFF] Add support for /map

[Sylvain Audi via Phabricator via llvm-commits]

saudi marked 5 inline comments as done.
saudi added inline comments.


================
Comment at: lld/COFF/MapFileMS.cpp:9
+//
+// This file implements the /map option in a format close to the one generated
+// by link.exe (based on observations)
----------------
ruiu wrote:
> It is a bit odd that we intend to print out in a format that is not exactly the same as Microsoft's. What is the difference? Can't we output the exact same output?
I used the same format observed from MS generated map files.
The remaining differences are the "f" and "i" flags shown in some of the symbol lines from link.exe, I couldn't figure out what they mean.
I fixed the comment, as it is not supposed to be just "close to" the link format.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70557/new/

https://reviews.llvm.org/D70557