[PATCH] D69556: [CodeGen] Move ARMCodegenPrepare to TypePromotion

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer accepted this revision.
SjoerdMeijer added a comment.
This revision is now accepted and ready to land.

Hi Sam, about the AArch64 results: I assume you targeted the A32 ISA, can you confirm that? Because that would mean we have 2 data points, at least 2 ISA for which this is beneficial: T32 and A32.

I've checked the latest PowerISA spec Version 3.0 B (https://ibm.ent.box.com/s/1hzcwkwf8rbju5h9iyf44wm94amnlcrv), and for the `cmp` instruction I don't see that extends can be folded into it like in A64 that would make this transformation less or not so beneficial; I don't see extends for register `RB`. Similarly, I've checked MIPS, and don't see them either there.

So, I think we have 2 data points, and enough suspicion that it is beneficial for other non-X86 targets too, like Eli said. I think that is enough.

Please wait a couple of working days with committing just in case people still want to run numbers.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69556/new/

https://reviews.llvm.org/D69556