[PATCH] D70855: [llvm-readobj/llvm-readelf] - Simplify the code that dumps versions.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Nov 29 06:50:02 PST 2019


grimar created this revision.
grimar added reviewers: jhenderson, MaskRay, rupprecht.
Herald added a subscriber: seiya.
Herald added a project: LLVM.
grimar added a parent revision: D70826: [llvm-readobj/llvm-readelf] - Reimplement dumping of the SHT_GNU_verneed section..

After changes introduced in D70495 <https://reviews.llvm.org/D70495> and D70826 <https://reviews.llvm.org/D70826> its now possible
to significantly simplify the code we have.

This also fixes an issue: previous code assumed that version strings
should always be read from the dynamic string table. While it is
normally true, the string table should be taken from the corresponding
sh_link field.


https://reviews.llvm.org/D70855

Files:
  llvm/test/tools/llvm-readobj/elf-verneed-invalid.test
  llvm/tools/llvm-readobj/ELFDumper.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70855.231532.patch
Type: text/x-patch
Size: 15358 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191129/4d41dc1d/attachment.bin>


More information about the llvm-commits mailing list