[PATCH] D70756: llvm-symbolizer: support DW_FORM_loclistx locations.

[Oliver Stannard (Linaro) via Phabricator via llvm-commits]

ostannard added inline comments.


================
Comment at: llvm/lib/DebugInfo/DWARF/DWARFContext.cpp:1081
+
+    if (Expected<std::vector<DWARFLocationExpression>> Loc =
+            Die.getLocations(DW_AT_location)) {
----------------
I'm seeing a crash in test `tools/llvm-symbolizer/frame-noname.s`, I think `Expected` requires it's error to be consumed when `getLocations` fails.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70756/new/

https://reviews.llvm.org/D70756