[PATCH] D70844: [InstCombine] Fix big-endian miscompile of (bitcast (zext/trunc (bitcast)))

Fri Nov 29 04:17:36 PST 2019

bjope marked an inline comment as done.
bjope added inline comments.

================
Comment at: llvm/test/Transforms/InstCombine/cast.ll:3-4
 ; Tests to make sure elimination of casts is working correctly
 ; RUN: opt < %s -instcombine -S | FileCheck %s
 target datalayout = "E-p:64:64:64-p1:32:32:32-p2:64:64:64-p3:64:64:64-a0:0:8-f32:32:32-f64:64:64-i1:8:8-i8:8:8-i16:16:16-i32:32:32-i64:32:64-v64:64:64-v128:128:128-n8:16:32:64"

----------------
lebedev.ri wrote:
> I think this needs two runlines:
> ```
> ; RUN: opt < %s -instcombine -S --data-layout=<> | FileCheck %s --check-prefixes=ALL,LE
> ; RUN: opt < %s -instcombine -S --data-layout=<> | FileCheck %s --check-prefixes=ALL,BE
> ```
> and drop hardcoded `datalayout`.
Sure, I'll precommit an update to make this test case run with both big/little endian.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70844/new/

https://reviews.llvm.org/D70844