[PATCH] D70431: [DebugInfo] Make describeLoadedValue() reg aware

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added inline comments.


================
Comment at: llvm/lib/Target/X86/X86InstrInfo.cpp:7586
+  assert(MI.getOpcode() == X86::MOV32rr && "Unexpected super-register case");
+  return ParamLoadedValue(MachineOperand::CreateReg(SrcReg, false), Expr);
+}
----------------
dstenb wrote:
> djtodoro wrote:
> > So, this covers all the cases of the s//uper-registers// except the `X86::MOV32rr` case?
> Sorry, what is the question here? We only handle MOV32rr there (?).
Sorry for the confusion.. I have made a mistake. :)
I was going to say that the line covers only the MOV64rr case when the described register is a super-register of the destination register. I was thinking about adding a comment above the line, but it is obvious, so I guess we do not need the one.



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70431/new/

https://reviews.llvm.org/D70431