[PATCH] D70789: [Attributor] Remove dereferenceable_or_null when nonull is present

Thu Nov 28 10:26:06 PST 2019

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LGTM.

In D70789#1762474 <https://reviews.llvm.org/D70789#1762474>, @uenoku wrote:

> In D70789#1762114 <https://reviews.llvm.org/D70789#1762114>, @jdoerfert wrote:
>
> > This was a problem for a while now:
> >  Can we have a test case to make sure we do not lose information, e.g. `deref_or_null(100) nonnull deref(4)` should not remove the `deref_or_null(100)`.
>
>
> In my understanding, deref_or_null(100) and nonnull imply deref(100) so  deref_or_null(100) can be deleted safely, correct?

Yes.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70789/new/

https://reviews.llvm.org/D70789