[PATCH] D70813: [AArch64][v8.3a] Don't emit LDRA '[xN]!' alias in disassembly.

[Simon Tatham via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rGacd7fe8636ab: [AArch64][v8.3a] Don't emit LDRA '[xN]!' alias in disassembly. (authored by simon_tatham).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70813/new/

https://reviews.llvm.org/D70813

Files:
  llvm/lib/Target/AArch64/AArch64InstrFormats.td
  llvm/test/MC/AArch64/armv8.3a-signed-pointer.s
  llvm/test/MC/Disassembler/AArch64/armv8.3a-signed-pointer.txt


Index: llvm/test/MC/Disassembler/AArch64/armv8.3a-signed-pointer.txt
===================================================================
--- llvm/test/MC/Disassembler/AArch64/armv8.3a-signed-pointer.txt
+++ llvm/test/MC/Disassembler/AArch64/armv8.3a-signed-pointer.txt
@@ -114,7 +114,7 @@
 [0x20,0x04,0x20,0xf8]
 [0x20,0x04,0xa0,0xf8]
 
-# CHECK: ldraa x0, [x1]!
-# CHECK: ldrab x0, [x1]!
+# CHECK: ldraa x0, [x1, #0]!
+# CHECK: ldrab x0, [x1, #0]!
 [0x20,0x0c,0x20,0xf8]
 [0x20,0x0c,0xa0,0xf8]
Index: llvm/test/MC/AArch64/armv8.3a-signed-pointer.s
===================================================================
--- llvm/test/MC/AArch64/armv8.3a-signed-pointer.s
+++ llvm/test/MC/AArch64/armv8.3a-signed-pointer.s
@@ -307,10 +307,10 @@
 // CHECK-REQ: error: instruction requires: pa
 // CHECK-REQ-NEXT:  ldrab x0, [x1]
   ldraa x0, [x1]!
-// CHECK-NEXT: ldraa x0, [x1]!  // encoding: [0x20,0x0c,0x20,0xf8]
+// CHECK-NEXT: ldraa x0, [x1, #0]!  // encoding: [0x20,0x0c,0x20,0xf8]
 // CHECK-REQ: error: instruction requires: pa
 // CHECK-REQ-NEXT:  ldraa x0, [x1]!
   ldrab x0, [x1]!
-// CHECK-NEXT: ldrab x0, [x1]!  // encoding: [0x20,0x0c,0xa0,0xf8]
+// CHECK-NEXT: ldrab x0, [x1, #0]!  // encoding: [0x20,0x0c,0xa0,0xf8]
 // CHECK-REQ: error: instruction requires: pa
 // CHECK-REQ-NEXT:  ldrab x0, [x1]!
Index: llvm/lib/Target/AArch64/AArch64InstrFormats.td
===================================================================
--- llvm/lib/Target/AArch64/AArch64InstrFormats.td
+++ llvm/lib/Target/AArch64/AArch64InstrFormats.td
@@ -1473,7 +1473,7 @@
                   (!cast<Instruction>(NAME # "indexed") GPR64:$Rt, GPR64sp:$Rn, 0)>;
 
   def : InstAlias<asm # "\t$Rt, [$wback]!",
-                  (!cast<Instruction>(NAME # "writeback") GPR64sp:$wback, GPR64:$Rt, 0)>;
+                  (!cast<Instruction>(NAME # "writeback") GPR64sp:$wback, GPR64:$Rt, 0), 0>;
 }
 
 //---


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70813.231433.patch
Type: text/x-patch
Size: 1886 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191128/517e4ad5/attachment.bin>