[PATCH] D70816: [yaml2obj] - Add a way to describe content of the SHT_GNU_verneed section with "Content".

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Nov 28 06:16:22 PST 2019


grimar added a comment.

In D70816#1762946 <https://reviews.llvm.org/D70816#1762946>, @jhenderson wrote:

> Given the number of similar sections that share this style (i.e. Content or Some Stuff - entries, relocations ...), I wonder if a refactor is in order to share the sort of thing you're adding here between the various section types?


We can probably move "Content" and "Size" to "Section" class or may be even to "Chunk". It probably will save not that much lines though (but still better than nothing). I need to think more about it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70816/new/

https://reviews.llvm.org/D70816





More information about the llvm-commits mailing list