[PATCH] D70810: [llvm-readelf/llvm-readobj] - Check version of SHT_GNU_verdef section entries when dumping.

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM, with one suggestion.



================
Comment at: llvm/test/tools/llvm-readobj/elf-verdef-invalid.test:238
+
+## Check how we handle the case when a version definition entry has an unsupported version.
+
----------------
This can be simplified to "Check how we handle a version definition entry with an unsupported version."

There may be other places where this sort of suggestion applies too. Sorry for not highlighting it before.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70810/new/

https://reviews.llvm.org/D70810