[PATCH] D70447: [Support] ThreadPoolExecutor fixes for Windows/MinGW

Wed Nov 27 22:00:15 PST 2019

mehdi_amini added a comment.

In D70447#1760618 <https://reviews.llvm.org/D70447#1760618>, @rnk wrote:

> How come we have both lib/Support/Parallel.cpp and lib/Support/ThreadPool.cpp? What is the difference? I thought this was the general LLVM threadpool and I was going to send this over to @mehdi_amini who added that in rG396abbb6f045232f92439dbce052db3177a474f9 <https://reviews.llvm.org/rG396abbb6f045232f92439dbce052db3177a474f9>, but I guess @zturner added Parallel.cpp.

LLD started the Parallel.h thread-pool in 2013, unfortunately they didn't do it in libSupport so it grew inside LLD. I added ThreadPool.cpp in 2015 to LLVM, I wasn't aware about the LLD implementation (that's what happens when utilities aren't put in libSupport...). Zachary noticed that later, and moved the LLD implementation in libSupport in 2017. However I haven't seen a plan for reconciliation the two.

I'm not fond of global state in general (this patch is also a good example of why), and so reluctant to the Parallel.cpp implementation.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70447/new/

https://reviews.llvm.org/D70447