[PATCH] D70757: [ms] Add @feat.00 magic symbol to COFF object files from AsmParser

[Eric Astor via Phabricator via llvm-commits]

epastor added a comment.

In D70757#1762394 <https://reviews.llvm.org/D70757#1762394>, @rnk wrote:

> There is existing nasm documentation covering this. Basically, this is something the programmer has to know if they want to target windows:
>  https://nasm.us/doc/nasmdoc7.html


Thanks, Reid! So to clarify: our standards for this are to match nasm for the current interface?

As for roundtripping... I'll have to check, but it seems likely to be a problem. If necessary, I'll withdraw this and leave it to be managed by whatever interface ends up used to emulate MASM. (ml.exe and ml64.exe both emit @feat.00 implicitly into their symbol tables, with ml.exe setting the LSB if /safeseh is passed.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70757/new/

https://reviews.llvm.org/D70757