[PATCH] D70784: [FileCheck] Given multiple -dump-input, prefer most verbose

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

I know we've had previous differences of opinion on how many combinations to test, and I'll bring it up again.  I think we really need:

- only one case where the two options are the same; that demonstrates a repeated option is not an error.
- minimum cases showing the higher one gets picked: never/fail, fail/always, always/help. By transitivity we conclude the others are fine.
- only one case for the other order, showing it's not first (or last) always wins.
- only two cases of environment/command, showing it's not one or the always wins.

So a total of 7 cases, rather than the 16 you have here.

The code is fine, the tests are fine, I think we just don't need to spend as much resource on the test here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70784/new/

https://reviews.llvm.org/D70784