[PATCH] D69275: Add constrained int->FP intrinsics

Kevin P. Neal via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 27 12:10:10 PST 2019


kpn marked an inline comment as done.
kpn added inline comments.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:18766
+                                  Op.getSimpleValueType())
+        .first;
+  }
----------------
craig.topper wrote:
> Don't we need to propagate the chain result too?
When given a strict FP node LowerOperation() will require that the resulting new node has the chain in the same place in the values. So, no, I don't think so unless we want to thread the std::pair all the way back up.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69275/new/

https://reviews.llvm.org/D69275





More information about the llvm-commits mailing list