[PATCH] D70779: AArch64: add support for newer Apple CPUs

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 27 12:10:10 PST 2019


fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

LGTM, but it might be good to wait with committing until next week, so people in the US have a chance to take a look as well.



================
Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:143
     MtuneLowerCase = llvm::sys::getHostCPUName();
-  if (MtuneLowerCase == "cyclone") {
+  if (MtuneLowerCase == "cyclone" || MtuneLowerCase.find("apple") == 0) {
     Features.push_back("+zcm");
----------------
It might be slightly more obvious to use MtuneLowerCAse.StartsWith("apple")


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70779/new/

https://reviews.llvm.org/D70779





More information about the llvm-commits mailing list