[PATCH] D69281: [FPEnv] Constrained FCmp intrinsics

[Cameron McInally via Phabricator via llvm-commits]

cameron.mcinally added a comment.

In D69281#1759494 <https://reviews.llvm.org/D69281#1759494>, @andrew.w.kaylor wrote:

> I would prefer a single intrinsic/opcode with additional predicates to handle signalling vs. quiet. My main reason is consistency with how the IEEE-754 spec describes comparisons, but that's a weak argument. @craig.topper mentioned to me that there are some additional opcodes that might need to be duplicated if you treat signalling and quiet as separate operations.


I don't have a strong opinion on this, but this would get weird for `compareQuietUnordered` and `compareQuietOrdered`. There are no signalizing counterparts for those.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69281/new/

https://reviews.llvm.org/D69281