[PATCH] D70761: scudo: Limit the number of bytes tested in a realloc test.
Peter Collingbourne via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 27 10:18:24 PST 2019
pcc updated this revision to Diff 231294.
pcc retitled this revision from "scudo: Reverse order of testing sizes for realloc." to "scudo: Limit the number of bytes tested in a realloc test.".
pcc edited the summary of this revision.
pcc removed subscribers: tellenbach, merge_guards_bot.
pcc added a comment.
Address review comment
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70761/new/
https://reviews.llvm.org/D70761
Files:
compiler-rt/lib/scudo/standalone/tests/combined_test.cpp
Index: compiler-rt/lib/scudo/standalone/tests/combined_test.cpp
===================================================================
--- compiler-rt/lib/scudo/standalone/tests/combined_test.cpp
+++ compiler-rt/lib/scudo/standalone/tests/combined_test.cpp
@@ -111,7 +111,7 @@
const scudo::uptr NewSize = DataSize + Delta;
void *NewP = Allocator->reallocate(P, NewSize);
EXPECT_EQ(NewP, P);
- for (scudo::uptr I = 0; I < scudo::Min(DataSize, NewSize); I++)
+ for (scudo::uptr I = 0; I < DataSize - 32; I++)
EXPECT_EQ((reinterpret_cast<char *>(NewP))[I], Marker);
}
Allocator->deallocate(P, Origin);
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70761.231294.patch
Type: text/x-patch
Size: 630 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191127/f6c1e786/attachment.bin>
More information about the llvm-commits
mailing list