[PATCH] D70653: [AutoFDO] Properly merge context-sensitive profile of inlinee back to outlined function

[Wei Mi via Phabricator via llvm-commits]

wmi added a comment.

I did performance test combing D70653 <https://reviews.llvm.org/D70653> and D70655 <https://reviews.llvm.org/D70655>, there was ~0.2% latency improvement in a benchmark, so that is good.



================
Comment at: llvm/include/llvm/ProfileData/SampleProfReader.h:363
+  /// FunctionSamples if it doesn't exist.
+  FunctionSamples *getOrCreateSamplesFor(const Function &F) {
+    std::string FGUID;
----------------
I found a potential problem here. When we create a new profile for a function when merging inline instance profile back, if the function somehow has no debug information, the annotation will fail and a warning will be issued. We may want to skip those functions without debug information (The warning is issued in SampleProfileLoader::getFunctionLoc)  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70653/new/

https://reviews.llvm.org/D70653