[PATCH] D70609: [DDG] Data Dependence Graph - Topological Sort
Bardia Mahjour via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Nov 27 08:45:25 PST 2019
bmahjour updated this revision to Diff 231270.
bmahjour added a comment.
One of the sanitizer builds failed due to a memory leak issue. http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-bootstrap/builds/14902
The reason for the leak is that when sorting I did not consider the nodes inside of the pi-block so they got removed from the DirectedGraph's list of nodes, and did not get freed when the DDG destructor got called.
I've updated the patch to fix the leak and reopened this revision for review.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70609/new/
https://reviews.llvm.org/D70609
Files:
llvm/include/llvm/Analysis/DDG.h
llvm/include/llvm/Analysis/DependenceGraphBuilder.h
llvm/lib/Analysis/DDG.cpp
llvm/lib/Analysis/DependenceGraphBuilder.cpp
llvm/test/Analysis/DDG/basic-a.ll
llvm/test/Analysis/DDG/basic-b.ll
llvm/test/Analysis/DDG/basic-loopnest.ll
llvm/test/Analysis/DDG/root-node.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D70609.231270.patch
Type: text/x-patch
Size: 45214 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191127/f8dbdeb0/attachment.bin>
More information about the llvm-commits
mailing list