[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

liu hui via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 27 06:45:40 PST 2019


lh123 marked 3 inline comments as done.
lh123 added inline comments.


================
Comment at: llvm/include/llvm/Support/CommandLine.h:47
+class FileSystem;
+IntrusiveRefCntPtr<FileSystem> getRealFileSystem();
+
----------------
kadircet wrote:
> now that we are also pulling the the function, I think it is OK to include the header instead.
Yes, we need to include `VirtualFileSystem.h`, `IntrusiveRefCntPtr` needs to know the complete definition of `FileSystem`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70769/new/

https://reviews.llvm.org/D70769





More information about the llvm-commits mailing list