[PATCH] D68209: [LiveDebugValues] Introduce entry values of unmodified params

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added a comment.

@jmorse Thanks for your comment!

In D68209#1761600 <https://reviews.llvm.org/D68209#1761600>, @jmorse wrote:

> This looks ready to go in, although I've no familiarity with the LLDB tests modified in the latest changed. As far as I can see, this is weakening some of the tests (and expecting more unavailable values) because the mechanism for identifying when a value is unchanged is now more conservative, and we drop more entry values?


Yes. The modification analysis here is more conservative in some cases, since we can not track a parameter's value copied into a register that is not callee saved (at the moment, unless we find out some improvement for that).
But, current approach will cover some entry values we did not cover so far. For example, in some cases, we can use the entry value of a parameter until it got changed, instead of using the entry values for the parameters which are not changed throughout a whole function.

Since I am not  familiar with LLDB so much, I will leave it to @vsk and @aprantl to take another look into the changes.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68209/new/

https://reviews.llvm.org/D68209