[PATCH] D70776: [llvm-readelf] - Make GNU style dumping of invalid SHT_GNU_verdef be consistent with LLVM style.

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 27 04:20:12 PST 2019


jhenderson added a comment.

In D70776#1761511 <https://reviews.llvm.org/D70776#1761511>, @grimar wrote:

> In D70776#1761507 <https://reviews.llvm.org/D70776#1761507>, @jhenderson wrote:
>
> > Looks okay to me. What does GNU do in this situation?
>
>
> It prints:
>
>   readelf: Warning: Section 1 has an out of range sh_link value of 255
>  
>   Version definition section '.gnu.version_d' contains 0 entries:
>     Addr: 0x0000000000000000  Offset: 0x000040  Link: 255 (<corrupt>)
>


Okay, thanks. Should we maybe print `<corrupt>` too, instead of `<invalid>`? I don't mind either way.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70776/new/

https://reviews.llvm.org/D70776





More information about the llvm-commits mailing list