[PATCH] D69828: [WIP][OpenMP] Lower taskwait using OpenMP IR Builder

Roger Ferrer Ibanez via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 27 02:31:26 PST 2019


rogfer01 marked an inline comment as done.
rogfer01 added inline comments.


================
Comment at: llvm/include/llvm/Frontend/OpenMPIRBuilder.h:81
+  /// \returns The insertion point after the barrier.
+  InsertPointTy CreateTaskwait(const LocationDescription& Loc);
+
----------------
jdoerfert wrote:
> If taskwait cannot cause control flow we don't need to return a new insert point, I think.
Ah I see, we want a similar behaviour to that of `IRBuilder` in which the new IP is updated after something has been emitted.

Makes sense.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69828/new/

https://reviews.llvm.org/D69828





More information about the llvm-commits mailing list