[PATCH] D70769: [Support] add vfs support for ExpandResponseFiles

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Nov 27 01:10:18 PST 2019


jhenderson added a comment.

Are there any instances where we DON'T want to get the real file system? If not, could the `*llvm::vfs::getRealFileSystem()` call be put inside `cl::ExpandResponseFiles`?



================
Comment at: llvm/include/llvm/Support/CommandLine.h:32
 #include "llvm/Support/ManagedStatic.h"
+#include "llvm/Support/VirtualFileSystem.h"
 #include "llvm/Support/raw_ostream.h"
----------------
Can llvm::vfs::FileSystem be forward declared and this moved into the .cpp?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70769/new/

https://reviews.llvm.org/D70769





More information about the llvm-commits mailing list