[PATCH] D70737: [Attributor] Move pass after InstCombine to futher eliminate null pointer checks

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

In D70737#1760841 <https://reviews.llvm.org/D70737#1760841>, @xbolva00 wrote:

> In D70737#1760839 <https://reviews.llvm.org/D70737#1760839>, @jdoerfert wrote:
>
> > Why is inscombine the pass that adds `nonnull` to `strchr`?
> >  This is not a good solution, I'll try to come up with the SCC version of the Attributor soon to add it to the inliner loop
>
>
> You were fine with this approach..... https://reviews.llvm.org/D53342.


I did not make the connection from SimplifyLibCalls to Instcombine. I think annotating library calls should live in SimplifyLibCalls.

Let me try to come up with the Attributor SCC pass so we can run it early on the entire module and during the inliner loop on an SCC at a time. That would solve the problem. OK? (We should keep the test though)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70737/new/

https://reviews.llvm.org/D70737