[PATCH] D70658: [LLD][ELF] - Make compression level be dependent on -On.

Tue Nov 26 17:20:55 PST 2019

smeenai added inline comments.

================
Comment at: lld/test/ELF/compressed-debug-level.test:23
+# HEADER: [Nr] Name        Type     Address  Off    Size
+# LEVEL1: [ 1] .debug_info PROGBITS 00000000 000094 00001c
+# LEVEL6: [ 1] .debug_info PROGBITS 00000000 000094 00001b
----------------
MaskRay wrote:
> smeenai wrote:
> > The size appears to depend on the zlib version. For example, I'm running with zlib 1.2.8, which manages to compress these contents to the same size with both level 1 and 6. Is there any way to make this agnostic to zlib version?
> I run zlib 1.2.11 and it works for me. Can you alter the input a bit to make the length different for level 1 and level 6, for zlib 1.2.8?
I fixed it with 75fd939bb917e8f843395684a2970d86bc0199c0.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70658/new/

https://reviews.llvm.org/D70658