[PATCH] D69828: [WIP][OpenMP] Lower taskwait using OpenMP IR Builder

[Johannes Doerfert via Phabricator via llvm-commits]

jdoerfert added a comment.

I think this is fine, one comment though.



================
Comment at: llvm/include/llvm/Frontend/OpenMPIRBuilder.h:81
+  /// \returns The insertion point after the barrier.
+  InsertPointTy CreateTaskwait(const LocationDescription& Loc);
+
----------------
If taskwait cannot cause control flow we don't need to return a new insert point, I think.


================
Comment at: llvm/include/llvm/Frontend/OpenMPIRBuilder.h:126
+  ///
+  /// \returns The insertion point after the barrier.
+  InsertPointTy emitTaskwaitImpl(const LocationDescription &Loc);
----------------
Copy & paste, also see my other comment.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69828/new/

https://reviews.llvm.org/D69828